Issue #52: Apostrophes break OS X client #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used in conjunction with the browser plugin, the browser plugin would reply before auth got a chance to process, and thus no auth would ever be applied and the directory would be immediately browseable. Setting the priority on the listener guarantees auth gets a higher priority than browser (which uses normal priority).
Many text editors will add a newline at the end of the file without asking the user.
…y explicitly encoding apostrophes as well.
…ers break the OS X client as well. Changed my approach to completely escape all path fragments, and this seems to be working for every file I throw at it. Fixes mikedeboer#52
… marks while fixing most other characters. Forgot to go back and test the original problem. This has been tested with quote marks, double quote marks, ampersands, dashes, spaces, etc. Fixes mikedeboer#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.