Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified to skip processing when the vertex attribute of primitive is None #2043

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Modified to skip processing when the vertex attribute of primitive is None #2043

merged 1 commit into from
Oct 1, 2023

Conversation

iory
Copy link
Contributor

@iory iory commented Oct 1, 2023

This PR avoids errors when loading collada (dae) files that do not have vertices by skipping the process if the vertex is None.

@mikedh mikedh changed the base branch from release-candidate to rc2 October 1, 2023 18:50
@mikedh mikedh changed the base branch from rc2 to release-candidate October 1, 2023 18:51
@mikedh mikedh changed the base branch from release-candidate to rc2 October 1, 2023 18:53
@mikedh
Copy link
Owner

mikedh commented Oct 1, 2023

Thanks for the fix!

@mikedh mikedh merged commit 5700fbd into mikedh:rc2 Oct 1, 2023
@mikedh mikedh mentioned this pull request Oct 1, 2023
Merged
@iory iory deleted the dae branch October 2, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iory @mikedh