Allow custom VHACD parameters #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thanks for taking this on, looks great!! Roger on holding off until upstream merges or otherwise I'm happy to maintain a fork if necessary. |
|
I'm not sure if there will be any movement on thomwolf/pyVHACD#3. How long do you think we should wait until considering a fork? |
|
Hey, I just created a fork and merged the two open PR's. It's releasing the wheels to pypi here: https://github.com/trimesh/vhacdx Thanks for the work on this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
trimeshside of what has been discussed in #2045.NOTE: This should be blocked until the
pyVHACDside is merged: thomwolf/pyVHACD#3Closes #2045