[BUG] fix rounding issue in uv_to_color()

[TooSchoolForCool]

Hi Mike,

I discovered an index out of bounds error in the to_color() function when converting TextureVisual to ColorVisuals.

The issue occurs in the uv_to_color() function here:

# get texture image pixel positions of UV coordinates
x = (uv[:, 0] * (image.width - 1)) % image.width
y = ((1 - uv[:, 1]) * (image.height - 1)) % image.height

# access colors from pixel locations
# make sure image is RGBA before getting values
colors = np.asanyarray(image.convert("RGBA"))[
    y.round().astype(np.int64), x.round().astype(np.int64)
]

The modulus (%) operation on float values can cause index out of bounds errors when rounding values near the bounds. For example:

1. Given uv[i, 0] == -26.05739974975586 and image.width == 456
2. Results in x[i] == 455.883113861084 after modulus operation x = (uv[:, 0] * (image.width - 1)) % image.width
3. When rounded, x.round().astype(np.int64) == 456
4. This exceeds valid image indices [0, 455], causing the error

I have fixed this issue in this pull request, please let me know if you have any further concerns!

Best,

Zeyu

[mikedh]

Thanks for the fix!! I suppose there are multiple ways of handling overflowing UV's like wrap vs clamp vs mirror and this selects "wrap" as the default here. This makes sense to me, and is a lot better than crashing!