Fix zsh completion #1108
Merged
Fix zsh completion #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ec533b introduced a bug which causes the 'hidden' cli parameter `__complete` to be ignored. Add a check for this parameter, so that it can pass to `cobra` Signed-off-by: Tom Whitwell <tom@whi.tw>
whi-tw
force-pushed
the
fix-completion
branch
from
612bba3
to
f618d56
Compare
|
Yeah I couldn't find a way to do it in cobra either - thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4ec533b introduced a bug which causes the 'hidden' cli parameter
__completeto be ignored.Add a check for this parameter, so that it can be correctly passed to
cobraThere is still an issue -
yq <tab>will suggest that a subcommand is run, not a file. I think 'pick eval by default' could be done in a more cobra-friendly way, but I just don't know enough about it to implement that