-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for --wrapScalar=false in properties encoder #1241
adding support for --wrapScalar=false in properties encoder #1241
Conversation
This looks really good - you just need to add test(s) into properties_test.go, this will also generate documentation so others know about the feature 👍🏼 |
463ba68
to
adf8a51
Compare
@mikefarah i've updated the test workflow a bit and added one for my added feature. if you disagree with the changes, i can work on a different solution. (bad internet, sorry for the double comment) Additionally, I would like to potentially take a stab at refactoring a bit of the test suite, but could do that in a separate PR. |
Thank you! There is a problem though in the documentation generated, it doesn't show the updated command to get the wrapping (e..g supplying |
1efe86d
to
23be0b0
Compare
@mikefarah sorry it took a few days to get back to you on this! i reverted my initial pass as it wasn't really in keeping with your original design, and i didn't want to start imposing my own opinions there. with this update, i've done the following:
let me know what you think :) |
I'm currently running into a scenario where it would be useful to wrap the value side of the output from the Properties encoder.
This PR is a first draft at that with some tests, please let me know if you'd like some more!