getOutput() does not trim the form feed character

[daveherman71]

In the Windows environment it appears that the stdOut is preceded by \x0C (ASCII Form Feed character).

This is a problem when the expected stdOut is a JSON response string which will not parse using json_decode() because of the "invisible" form feed character.

The PHP trim() function does not strip these characters by default so the suggested change would be to replace the getOutput() function as follows

    public function getOutput($trim = true)
    {
        return $trim ? trim($this->_stdOut, " \t\n\r\0\x0B\x0C") : $this->_stdOut;
    }

And perhaps extend this change to getError() and getStdErr() as well.

[mikehaertl]

What if these characters are part of some expected output? We should not just trim withouth warning. We could have an option (default off), though. But I wonder if it's really our library that should take care of this.

Did you maybe investigate what causes this extra character? Does it happen in both cases, with useExec = true/false?

[mikehaertl]

Sorry, I should have looked at your code more closely. I forgot that we already trim by default. So maybe it's really safe to add these extra characters. I'll have a look.

[mikehaertl]

@daveherman71 I've created a PR. Could you have a look and maybe also test if it works for you? I don't use Windows.

[daveherman71]

Thanks, that version works.

Please note that this module was installed as a dependency of phpwkhtmltopdf - I did not install it myself.

[mikehaertl]

Please note that this module was installed as a dependency of phpwkhtmltopdf - I did not install it myself.

Hmm, ok, but with phpwkhtmltopdf there should be no problem with missing trim characters? So I assume you also use the library for other shell commands.

Anyway, I've just released 1.7.0 containing this fix. Thanks for your help.