This repository has been archived by the owner on May 3, 2023. It is now read-only.
Clarify readme #29
Merged
Clarify readme #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
approved these changes
Jul 9, 2019
|
I like it, and I've been known for obtuse instructions so the clarifying is appreciated. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I thought the instructions could be improved to make it more explicitly explained that you have to do the steps in that order, and what the first step meant. I think my prettier config also made some small changes, sorry about that, shouldn't be hard to make it just how you like.
Specifically, "How can you do this?" followed by a list makes it seem like there are multiple ways to go about it, especially with the first list item being "Convert your app to AndroidX via the [standard AndroidX migration]"
I'm a native English speaker, and was confused by the instructions, so I missed that you have to run the refactoring tool first and then use the libraries jelifier and jetlify, and that slowed down my development /slash/ gave me a wonderful learning opportunity which I'm thankful for, one of those.
Thank you very much for providing tooling for making upgrading react native easier! Have a great day!