Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LF emails can't be parsed anymore #1129

Closed
ahorek opened this issue Jul 3, 2017 · 2 comments
Closed

LF emails can't be parsed anymore #1129

ahorek opened this issue Jul 3, 2017 · 2 comments
Assignees
@jeremy
Milestone
2.7.0

Comments

@ahorek
Copy link
Contributor

ahorek commented Jul 3, 2017

removed in #1113 / master branch

I have many eml files in my specs with just LF separator, that passes on 2.6.6 stable

HEADER
LFLF
BODY

when normalization was removed, header separator doesn't work with it anymore, the parser thinks that the whole email is a header which is wrong.

HEADER_SEPARATOR = /#{CRLF}#{CRLF}/

according to the RFC, header separator should be always 2x CRLF
https://www.ietf.org/rfc/rfc2822.txt

so my question is, should eml files with just LF separators be parsable or not?
It doesn't comply with RFC, but standard mail clients like Outlook or Thunderbird can open and work with these files just fine. It also used to work with mail 2.6.6.
@jeremy
Copy link
Collaborator

jeremy commented Jul 3, 2017

Yep, looking at supporting this before release. Correctness first!

Some related discussion on the commit: 21222e1#commitcomment-22366140

@jeremy jeremy added this to the 2.7.0 milestone Jul 3, 2017
@jeremy jeremy self-assigned this Jul 3, 2017
@ahorek
Copy link
Contributor Author

ahorek commented Jul 4, 2017

great, thanks!

jeremy added a commit to jeremy/mail that referenced this issue Oct 24, 2017
@jeremy
Parse emails with \n newlines if they don't contain binary content
1997770 
Binary-safe newline conversion ensures that attachments don't get
corrupted. Requires that text is ASCII-only.

Fixes mikel#1129
References mikel#1113
@jeremy jeremy mentioned this issue Oct 24, 2017
Merged
jeremy added a commit that referenced this issue Oct 24, 2017
@jeremy
Parse emails with \n newlines if they don't contain binary content
f8b57f6 
Binary-safe newline conversion ensures that attachments don't get
corrupted. Requires that text is ASCII-only.

Fixes #1129
References #1113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremy jeremy

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@jeremy @ahorek