Mail attempts to decode a mail message twice when using exim

[dukha]

When trying the basic example in the readme with exim, I only received and error:

NoMethodError: undefined method encoded' for #String:0x0000000947f9d8 from /home/mark/.rvm/gems/ruby-2.0.0-p247/gems/mail 2.5.4/lib/mail/network/delivery_methods/exim.rb:46:inblock in call'

The mail message should have been an instance of the Mail class which respond to 'encoded', not a string.

It turns out the encoded is being called twice, once in the super class(Mail::Sendmail) and once in the subclass Mail::Exim.

My fix was to remove encoded from the Mail:Exim

def self.call(path, arguments, destinations, encoded_mail)
   popen "#{path} #{arguments}" do |io|
  io.puts encoded_mail.to_lf
  io.flush
   end
 end

This research was done in 2.5.4, however it looks like it is still in the master on github.

[bf4]

Thanks for this. Are you able to write a test that demonstrates this behavior?

[dukha]

Hi Ben
I could but I have time pressure right now. How much time to I have.

Regards

Mark

On 15 January 2015 at 14:14, Benjamin Fleischer notifications@github.com
wrote:

Thanks for this. Are you able to write a test that demonstrates this
behavior?

—
Reply to this email directly or view it on GitHub
#814 (comment).

[cheenwe]

same question

/root/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/mail-2.6.4/lib/mail/network/delivery_methods/exim.rb:47:in `block in call': undefined method `encoded' for #<String:0x007f8fd34eec28> (NoMethodError)
        from /root/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/mail-2.6.4/lib/mail/network/delivery_methods/sendmail.rb:73:in `popen'
        from /root/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/mail-2.6.4/lib/mail/network/delivery_methods/sendmail.rb:73:in `popen'
        from /root/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/mail-2.6.4/lib/mail/network/delivery_methods/exim.rb:46:in `call'
        from /root/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/mail-2.6.4/lib/mail/network/delivery_methods/sendmail.rb:57:in `deliver!'
        from /root/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/mail-2.6.4/lib/mail/message.rb:253:in `deliver!'
        from email.rb:17:in `<main>'

[jeremy]

Fixed by 67ac9bb, backport of #689.