Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parsing of LF-only body with separate parts #1319

Closed
wants to merge 1 commit into from
Closed

Handle parsing of LF-only body with separate parts #1319

wants to merge 1 commit into from

Conversation

sebbASF
Copy link
Collaborator

@sebbASF sebbASF commented Feb 13, 2019

Conversion of body to CRLF does not help here because body is not ascii_only
so does not get converted. Instead to search for CR?LF (optional CR)
in which case conversion to CRLF is unnecessary.

Conversion of body to CRLF does not help here because body is not ascii_only
so does not get converted. Instead to search for CR?LF (optional CR)
in which case conversion to CRLF is unnecessary.
@jeremy
Copy link
Collaborator

jeremy commented Feb 13, 2019

Thanks @sebbASF! Dig this.

@akissinger
Copy link

I ran into this error myself, and nearly made the same PR (without the nice unit tests of course...). Is this going to get merged at some point?

@toofar toofar mentioned this pull request Jul 23, 2022
@mikel mikel changed the base branch from 2-7-stable to 2-8-stable December 3, 2022 09:07
@mikel mikel changed the base branch from 2-8-stable to master December 3, 2022 09:07
@mikel mikel changed the base branch from master to 2-7-stable December 3, 2022 09:07
@mikel mikel added the RSpec label Dec 3, 2022
@mikel
Copy link
Owner

mikel commented Dec 3, 2022

Waiting for specs to be working on the master forward port of this.

@sebbASF
Copy link
Collaborator Author

sebbASF commented Dec 14, 2022

Redundant as 2.7 no longer in development

@sebbASF sebbASF closed this Dec 14, 2022
@sebbASF sebbASF deleted the parse_lf branch December 14, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants