Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. #1510

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

mikel
Copy link
Owner

@mikel mikel commented Dec 3, 2022

Original PR message from #1441

While reviewing the code to ensure an interoperability issue, I dove into the source. I found my answer (mail does the right thing, by not caring about TLS itself, but delegating this to configuration and OpenSSL) and I also found a lot of trailing whitespace.

Since I dislike that I let rubocop auto-correct that for me and commited the results.

I intentionally did not push a new dependency on you. That would be a hugely different PR and discussion.

This, however, should be easy to merge and help future PRs to stick to the CONTRIBUTING guidelines.

@mikel mikel added the Ready to Merge Ready to merge once specs are green label Dec 3, 2022
@mikel mikel merged commit c9ea62c into master Dec 3, 2022
@mikel mikel deleted the chore/remove-trailing-whitespace branch December 3, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to Merge Ready to merge once specs are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants