Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test string is 1 char short of 78 #1568

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Test string is 1 char short of 78 #1568

merged 3 commits into from
Jan 3, 2024

Conversation

sebbASF
Copy link
Collaborator

@sebbASF sebbASF commented Feb 22, 2023

This fixes #1567

eval
eval previously approved these changes Jan 3, 2024
eval
eval previously approved these changes Jan 3, 2024
@eval
Copy link
Collaborator

eval commented Jan 3, 2024

Removing that CI-config commit prevented me from merging. Can you rebase @sebbASF so I can merge?

Copy link
Collaborator Author

@sebbASF sebbASF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to apply PR #1599

@eval
Copy link
Collaborator

eval commented Jan 3, 2024

@sebbASF it seems we can't merge as we're both authors of the PR currently.... As 1599 is applied, could you try force-pushing the remaining commit? Maybe we can merge then.

@eval eval merged commit 3dd53e0 into master Jan 3, 2024
15 checks passed
@sebbASF sebbASF deleted the issue1567 branch January 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test string is 1 char short of 78
2 participants