Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1536 #1577

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Backport 1536 #1577

merged 3 commits into from
Jan 3, 2024

Conversation

eval
Copy link
Collaborator

@eval eval commented Apr 18, 2023

This backports #1536 to the 2-8-stable-branch.

Why

Though mail v2.8 enabled turning TLS/STARTTLS options off (this surfaced as net-smtp's default value for starttls went from false to :auto), it also introduced some new problems:

  • having ssl false would ignore any starttls-setting
  • enable_starttls: false ignores the enable_starttls_auto-flag.

These issues were fixed on mainline but I think it's worth to have these in a new 2.8 release as well.

Impact

Possible outcomes:

  • having either ssl or tls truthy ánd having truthy values for any of enable_starttls*-flags set will now raise an ArgumentError.
    While mail is stricter in this regard, net-smtp would already consider this a non-acceptable config.
  • another scenario: a config with enable_starttls false and enable_starttls_auto true resulted in starttls :auto <v2.8, in v2.8 this resulted in starttls false and would now again result in:auto.

Did I miss anything?

@eval
Copy link
Collaborator Author

eval commented Apr 18, 2023

@ahorek @sebbASF review appreciated.

@eval eval merged commit ef51505 into 2-8-stable Jan 3, 2024
15 checks passed
@eval
Copy link
Collaborator Author

eval commented Jan 3, 2024

Merging as this was reviewed/discussed in the master-PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant