Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #1536 to the
2-8-stable
-branch.Why
Though
mail
v2.8 enabled turning TLS/STARTTLS options off (this surfaced as net-smtp's default value forstarttls
went fromfalse
to:auto
), it also introduced some new problems:ssl
false
would ignore any starttls-settingenable_starttls: false
ignores theenable_starttls_auto
-flag.These issues were fixed on mainline but I think it's worth to have these in a new 2.8 release as well.
Impact
Possible outcomes:
ssl
ortls
truthy ánd having truthy values for any ofenable_starttls*
-flags set will now raise an ArgumentError.While
mail
is stricter in this regard, net-smtp would already consider this a non-acceptable config.enable_starttls false
andenable_starttls_auto true
resulted instarttls :auto
<v2.8, in v2.8 this resulted instarttls false
and would now again result in:auto
.Did I miss anything?