Handle a wide variety of non-rfc Message-Id formats #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle Message-Id formats such as: * <id_left@id_right... * <id_left... * <id_left> * id_left@id_right * id_left Handle comma separated message ids.
|
Exchange, in particular will truncate long References fields with "..." leading to some message-ids ending with that string. Also, in practice, I see comma-separated lists of message-ids in the References field as often (or more often) than the correct space separated lists. |
| :local_dot_atom_s, | ||
| :qstr_s, :qstr_e, | ||
| :local_quoted_string_e, | ||
| :comment_s, :comment_e |
There was a problem hiding this comment.
looks like the indentation is different in your change?
|
This looks pretty good at first glance. Is there any reason to include "," in message_id instead of using the solution you used in #606? I think I prefer only having the comma in message_ids, it's a little more clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Message-Id formats such as:
Handle comma separated message ids.