Fixing #408 by not standarizing whitespace #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be a better fix, that can standardize whitespace outside of the binary blob, but I feel this is a good step forward
|
@malmckay What does this do to nominally plain-text emails that have been sent with a Binary content-type but with "\n" as a line-break? Do we actually want to look at the content type as well? |
|
@ConradIrwin Good point. I looked at that in a slightly different way: If content-type is text and transfer-encoding is binary should we standardize line-breaks in the email body to CRLF? I think not. Mail.gem's parsing (by this point) is not affected, and I don't believe Mail.gem users should assume CRLF for the body. |
Conflicts: lib/mail/message.rb
|
Folded in to #1113 😊 |
jeremy
added a commit
that referenced
this pull request
May 22, 2017
* Omit initial CRLF linefeed conversion since CRLF are required newline separators. We shouldn't need to convert bare CR or LF. Update our fixture emails to use CRLF throughout. Closes #609. Fixes #408. * Drop quoted-printable CRLF conversion. This was introduced to harmonize with Ruby's \n-based line endings. But this breaks Q-P encoding with binary data. It's not *meant* for binary data, but we don't yet take adequate measures to use base64 for these cases. Reverts #496. Fixes #1010. Closes #1113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a better fix, that can standardize line breaks that are outside of the binary blob, but I feel this is a good step forward
Parsing binary encoded attachments still fails for most jpgs in 1.8.7 (1.9+ is fine). Without this patch most binary encoded attachments fail in all versions, so, again, I feel this is good step forward.
PS This is a repeat pull request, my previous one was from HEAD, which included other commits