Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using hasOwnProperty from the object prototype (nodejs v6) #59

Merged
merged 1 commit into from
Jun 19, 2016
Merged

Switch to using hasOwnProperty from the object prototype (nodejs v6) #59

merged 1 commit into from
Jun 19, 2016

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Apr 29, 2016 •
edited
Loading

Since the response from url.parse no longer inherits from it: nodejs/node#6289

@Page-
Switch to using hasOwnProperty from the object prototype since the re…
47d53c4 
…sponse from url.parse no longer inherits from it.
@Page- Page- changed the title Switch to using hasOwnProperty from the object prototype since the response from url.parse no longer inherits from it. Switch to using hasOwnProperty from the object prototype Apr 29, 2016
@Page- Page- changed the title Switch to using hasOwnProperty from the object prototype Switch to using hasOwnProperty from the object prototype (nodejs v6) May 2, 2016
@emilong
Copy link

emilong commented May 10, 2016

FWIW, I think the prototype change was in nodejs/node#6289

@Page-
Copy link
Contributor Author

Page- commented May 10, 2016

You're right, that's the PR I meant to link - updated the original comment

@mserege
Copy link

mserege commented Jun 3, 2016

Any chance to get this PR merged soon? Last issue left using Node v6.

@emilong
Copy link

emilong commented Jun 8, 2016

I hate to "me too," but this is also the last issue for me preventing moving to Node 6.

@emilong emilong mentioned this pull request Jun 8, 2016
Closed
@mikenicholson mikenicholson merged commit 47d53c4 into mikenicholson:master Jun 19, 2016
@mikenicholson
Copy link
Owner

Thanks for PR and my sincerest apologies for taking so long to address this. Life has kept me from being able to dedicate any time to my projects.

I've also updated the travis ci file to always build against the latest release so I can be notified when compatibility issues crop up.

@emilong
Copy link

emilong commented Jun 20, 2016

Thanks, @themikenicholson! Definitely appreciate your time and this library. 😄 Looking forward to the release.

@mikenicholson
Copy link
Owner

Release will be coming out tonight as soon as I resolve one more issue.

@Page- Page- deleted the nodejs-6 branch June 20, 2016 17:19
@Page- Page- restored the nodejs-6 branch June 20, 2016 17:19
ddolcimascolo pushed a commit to linagora/passport-jwt that referenced this pull request Sep 9, 2016
Fixed Node 6 Object.hasOwnProperty. mikenicholson#59
21a092a
@z38 z38 mentioned this pull request Sep 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Page- @emilong @mserege @mikenicholson