Add GPL library definitions #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That STRING_TOO_LARGE error was triggered when clicking the cert4android license information. |
mbiebl
force-pushed
the
gpl-license
branch
3 times, most recently
from
60ce815
to
5f9013f
Compare
|
Ok that |
|
@mikepenz I've considerably reworked the PR. Please have another look. |
|
fwiw, the lgpl 2/3 license definitions would probably benefit from such a rework as well. The current rendering of those licenses doesn't look too good. If you want, I can prepare a separe PR for that. |
|
@mbiebl thank you so much that's great! I will most likely do the review + merge + release this weekend. Sounds great :) anything to improve is always appreciated! |
|
A new release would be perfect, as I want to make use of the GPL library definitions without having to copy&pasting it into my project. Thanks a lot! |
Ack, will have a look at the LGPL 2/3 definitions then and submit a separate PR. |
mbiebl
force-pushed
the
gpl-license
branch
4 times, most recently
from
75d8285
to
96e55f2
Compare
Based on the HTML version https://www.gnu.org/licenses/old-licenses/gpl-2.0-standalone.html Stripped off unnecessary markup like anchors which is not rendered by AboutLibraries anyway.
Based on the HTML version https://www.gnu.org/licenses/gpl-3.0-standalone.html Stripped off unnecessary HTML markup like anchors and replaced “ and ” with a simple " to not hit the STRING_TOO_LARGE problem which is a result of string constants being limited to 64K. Fixes: mikepenz#426
|
Thank you so much again for this PR |
mbiebl
added a commit
to messageconcept/PeopleSyncClient
that referenced
this pull request
Apr 2, 2019
DAVx5 and its libraries are licensed under the GPL3. This requires a newer AboutLibraries version which provides that license definition. See mikepenz/AboutLibraries#428. Bump AboutLibraries version to 6.2.3 for that. This newer version in turn requires compatibility with Java 8. See mikepenz/AboutLibraries@4f7d4b8 and https://developer.android.com/studio/write/java8-support
1 task
|
It seems the current main branch no longer contains the library definitions for GPL/LGPL. |
|
Thank for your reply. |
|
Related to that, I tried to add license information (for a library that is pulled in via a git submodule) via But the license is not shown in the about information. Am I doing something wrong? |
|
I believe it's best to have a new issue for that and discuss there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add license definitions for GPL 2.0 and 3.0
For GPL 3.0 I seem to be hitting an "interesting" problem:
Please double check the STRING_TOO_LARGE problem before merging.