Swipe events for SwipeDrawer behaviour #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepenz
reviewed
Nov 6, 2020
Comment on lines
96
to
97
| viewHolder.itemView.translationX = 0f | ||
| viewHolder.itemView.translationY = 0f |
There was a problem hiding this comment.
Could you please describe why we need to reset the translation for this change?
There was a problem hiding this comment.
You're right, we don't need that. I just did a blind copy/paste from SimpleSwipeCallback. My mistake
mikepenz
approved these changes
Nov 7, 2020
|
Maybe I'm asking too much, but would it be possible to have these changes into a new release when you find the time to do so ? Thanks a bunch 🌞 |
|
@RobbWatershed oh. I am sorry that I haven't already done so. |
No worries. Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional callback interface to
SimpleSwipeDrawerCallbackSimpleSwipeDrawerCallback.ItemSwipeCallback.itemSwiped: Called when a drawer has been swiped (same bahaviour asSimpleSwipeCallback.ItemSwipeCallback.itemSwiped)SimpleSwipeDrawerCallback.ItemSwipeCallback.itemUnswiped: Called when a drawer has been un-swiped (= returns to its default position)SwipeDrawerListActivityto log these events.