Merge pull request #1122 from mikepenz/fix/1121

Revert optimisation to skip processing of scucessful tests
mikepenz · Jun 22, 2024 · db71d41 · db71d41
2 parents eb1a2b2 + 2d70fb2
commit db71d41
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 41 deletions.
diff --git a/__tests__/testParser.test.ts b/__tests__/testParser.test.ts
@@ -443,22 +443,11 @@ action.surefire.report.email.InvalidEmailAddressException: Invalid email address
  ])
  })
 
- it('should skip disabled tests when annotatePassed=false', async () => {
+ it('should parse disabled tests', async () => {
  const {totalCount, skipped, annotations} = await parseFile('test_results/issues/testDisabled.xml', '*')
  const filtered = annotations.filter(annotation => annotation.annotation_level !== 'notice')
  const notice = annotations.filter(annotation => annotation.annotation_level === 'notice')
 
- expect(totalCount).toBe(22)
- expect(skipped).toBe(10)
- expect(filtered.length).toBe(6)
- expect(notice.length).toBe(0)
- })
-
- it('should parse disabled tests as notices when annotatePassed=true', async () => {
- const {totalCount, skipped, annotations} = await parseFile('test_results/issues/testDisabled.xml', '*', true)
- const filtered = annotations.filter(annotation => annotation.annotation_level !== 'notice')
- const notice = annotations.filter(annotation => annotation.annotation_level === 'notice')
-
  expect(totalCount).toBe(22)
  expect(skipped).toBe(10)
  expect(filtered).toStrictEqual([

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/testParser.ts b/src/testParser.ts
@@ -313,12 +313,6 @@ async function parseSuite(
  skipped++
  }
 
- // If this won't be reported as a failure and processing all passed tests
- // isn't enabled, then skip the rest of the processing.
- if (annotationLevel !== 'failure' && !annotatePassed) {
- continue
- }
-
  // in some definitions `failure` may be an array
  const failures = testcase.failure
  ? Array.isArray(testcase.failure)