Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates for readability improvements. #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ShararAwsaf
Copy link

@ShararAwsaf ShararAwsaf commented Jun 7, 2020

Improvements include

  • feistel.py

    • updated _xor to use the system specific byte order
    • included a split method for readability and to prevent repetition
    • changed round keys to lambda function instead of storing a list of keys
    • reverse traversal has been updated in decrypt method for readability
  • encrypt.py

    • merged the encryption and decryption steps using an operation variable to avoid repetition
  • iterators.py

    • fixed a minor is where the block size was set to constant 64
  • utils.py

    • includes xor function as a cleanup process for modes.py
  • modes.py

    • made changes to CBC and CTR to use utils and moved the mode specific variables for CBC to be included inside the CBC class instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant