Simplifications in wake of PCL 1.8.0 #41
Conversation
|
Just wrapping up a local Indigo build (on El Cap), which started from a wiped Homebrew, so I think this is good to go in.
Nevermind, went ahead and did that, so that's even better then. |
mikepurvis
changed the title
| @@ -125,8 +115,7 @@ do_install() | |||
| rosinstall_generator ${ROS_CONFIGURATION} ${ROS_EXTRA_PACKAGES} --rosdistro ${ROS_DISTRO} --deps --tar > ${WS}.rosinstall | |||
| wstool init -j8 src ${WS}.rosinstall | |||
|
|
|||
| # Grabbing these older meshes allows rviz to run with Ogre 1.7 rather than Ogre 1.8+. Although formulae and patches | |||
| # exist to build Ogre 1.9, rviz, and Gazebo together, I have found this approach to be the most solid and consistent. | |||
| # Grabbing these older meshes allows rviz to run with Ogre 1.7 rather than Ogre 1.8+. | |||
| if [ -d src/rviz ]; then | |||
| pushd src/rviz/ogre_media/models | |||
| curl https://raw.githubusercontent.com/ros-visualization/rviz/hydro-devel/ogre_media/models/rviz_cone.mesh > rviz_cone.mesh | |||
There was a problem hiding this comment.
@wjwwood What's the chance that rviz could include these meshes for multiple Ogre versions, and use a compile-time switch to select between them? It would be a lot more elegant than me doing this awfulness here.
There was a problem hiding this comment.
@mikepurvis I'd review a pull request like that, but honestly all supported versions of rviz technically require Ogre 1.8+. We should try to address the problems with the newer ogre formula in Homebrew instead.
There was a problem hiding this comment.
The real problem with Ogre 1.9 was Gazebo IIRC, although the last time I checked was with gz5, so things may well have changed since then. That said, the fact that osrf/simulation/ogre still installs 1.7.4 does seem like a vote of non-confidence, though maybe yourself or @scpeters can speak more to that.
In any case, I don't have the will or energy to maintain my own homebrew formulas; this installer is absolutely meant to guide users down the path of least resistance, whatever that happens to be at a given moment in time.
There was a problem hiding this comment.
Sorry for the delayed response; I missed this at the time.
Most of our gazebo testing at the moment is on trusty with ogre 1.8, but we have also made lots of fixes so that it works with ogre 1.9, which is the default on xenial. So gazebo is compatible with ogre 1.8-1.9 on linux; I think the main issue is testing the homebrew formulae for ogre 1.8/1.9 in osrf/homebrew-simulation#24 which hasn't been a huge priority for me, since the 1.7.4 formula still seems to work for gazebo. I'm happy to help review that pull request, but I probably won't take the lead any time soon.
There was a problem hiding this comment.
The Ogre 1.9 formula doesn't look too bad— it's really just two brief patches: https://github.com/osrf/homebrew-simulation/pull/24/files#diff-0bfad96e7da860a50fe01709e5f95ea0
The big questions from my side would then be:
- Would you be willing for
osrf/simulation/ogreto become Ogre 1.9, or would we want it on a versioned dep? - What would be story for bottled Gazebo?
The ideal from my side here would obviously be to have ros-install-osx depend on an Ogre and Gazebo version that are both bottled, and have rviz build from source against the same Ogre version. I can do rosdep overrides and so-on handle the rviz side of it, but I'd like to take advantage of whatever you're able to bottle.
There was a problem hiding this comment.
Recently I've been adding version numbers to all the osrf/simulation formulae. If you change a formula name, all bottles have to be rebuilt, so it's not something to take lightly. I'd be happy for any gazebo formulae that support ogre 1.9 to depend on it, including the one-time cost of rebuilding the bottles.
|
awesome, thanks! |
Also includes migrating to Gazebo 7, and using brewed numpy, both of which will require some further testing.
@hawesie @spmaniato @ahundt