Modify Nordic sniffer payload length after decrypt #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wireshark cannot parse packets when payload length is not set correctly. This adds a hook to modify packet headers right before writing them to the output file and uses it to correctly set the payload length in the Nordic header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this fixes an issue where Wireshark cannot parse packets in the Nordic BLE format when the payload length in the header is not set correctly. This adds a function hook to modify packet headers right before writing them to the output file and uses it to correctly set the payload length in the Nordic header.
The only (unofficial?) documentation of the protocol that Nordic sniffers use I could find is https://github.com/wireshark/wireshark/blob/master/epan/dissectors/packet-nordic_ble.c. However, this does not specify how to actually detect the protocol legacy version 0; if you know how to do that, feel free to add support for it 😄
Cheers,
bitcubik