-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints #37
Comments
What's missing? |
I've seen these in other codebases before but didn't really know what they were for.
Ref: https://peps.python.org/pep-0561/#packaging-type-information
Ref: https://peps.python.org/pep-0561/#type-checker-module-resolution-order So basically this just tells mypy (or whatever) that dependents should use the types in this package? Is this blocking for you? |
Not blocking but will help prevent typing related bugs downstream |
May be a simple as adding a py.typed marker, otherwise we have type ignore imports
The text was updated successfully, but these errors were encountered: