fix: publish types #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshultz
reviewed
Aug 2, 2023
| @@ -213,7 +213,7 @@ def create_transaction( | |||
| ) | |||
|
|
|||
| # we need a gas price for a valid transaction | |||
| if not gas_price and not max_fee_per_gas: | |||
| if gas_price is None and max_fee_per_gas is None: | |||
There was a problem hiding this comment.
According to types, neither of these are None-able. And since you pointed out it's not required, I just pulled this check in #42. Mind removing this?
There was a problem hiding this comment.
Nevermind, I'll fix it after the fact.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where type declarations were not visible to consumer packages.
Also fixes issue where could not have gas price of 0
fixes: #37
fixes: #39