Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw errors on chain IDs above what app-ethereum plays well with #47

Merged
merged 1 commit into from
Aug 13, 2023
Merged

fix: throw errors on chain IDs above what app-ethereum plays well with #47

merged 1 commit into from
Aug 13, 2023

Conversation

mikeshultz
Copy link
Owner

@mikeshultz mikeshultz commented Aug 13, 2023 •
edited
Loading

Throw errors on chain IDs app-ethereum cannot handle.

Thanks to @antazoey for the tip on setting the eth_chainId RPC response for EthereumTesterProvider to fix the web3.py tests.

Ref #41

@mikeshultz mikeshultz added the bug Something isn't working label Aug 13, 2023
@mikeshultz mikeshultz self-assigned this Aug 13, 2023
@mikeshultz mikeshultz merged commit 1f306c7 into master Aug 13, 2023
5 checks passed
@mikeshultz mikeshultz deleted the large-chainid-error branch August 13, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikeshultz mikeshultz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeshultz