Skip to content

Commit

Permalink
test: correct execution runner for coverage report
Browse files Browse the repository at this point in the history
Prior refactoring to use `poetry` for dependency management, the
`coverage` command was executed directly. This was changed to use
`poetry run` to ensure the correct version of `coverage` was used.

However, the `coverage report` command was not updated to use `poetry
run` and thus was not using the correct version of `coverage`.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
  • Loading branch information
miketheman committed Dec 29, 2022
1 parent edb216c commit 5c06093
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
- name: Prepare project for development
run: poetry install
- name: Test with pytest
run: poetry run coverage run -m pytest ; coverage report --show-missing
run: poetry run coverage run -m pytest ; poetry run coverage report --show-missing
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ endif
@touch $(INSTALL_STAMP)

test: $(INSTALL_STAMP)
@poetry run coverage run -m pytest $(PYTEST_FLAGS) ; coverage report --show-missing
@poetry run coverage run -m pytest $(PYTEST_FLAGS) ; poetry run coverage report --show-missing

dist: clean $(INSTALL_STAMP)
@poetry build
Expand Down

0 comments on commit 5c06093

Please sign in to comment.