refactor/fix: move logic into setup phase and correct order #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/refactor-autouse
branch
from
cff29a1
to
8f5fb28
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
miketheman
force-pushed
the
miketheman/refactor-autouse
branch
from
430ba8e
to
fae0c2a
Compare
miketheman
force-pushed
the
miketheman/refactor-autouse
branch
from
fae0c2a
to
1b33d25
Compare
When the plugin started out, I didn't know how to use the `runtest_setup` phase, so I used an automatically-used fixture. Once the hook usage was introduced, I can now consolidate a lot of the behavior logic ion one place. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
May duplicate some of the other tests, but I wanted to make sure this was clear. I may refactor other tests later - it's unclear how to measure how many times a line is hit right now. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
The previous configuration allowed for `allow-hosts` to be passed without `--disable-socket` to implicitly activate blocking. This was confusing and inconsistent so we now require it to enable the global behavior. This introduces a little more complexity to the setup method, but is more clear as to what is actually happening. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/refactor-autouse
branch
from
1b33d25
to
e4fff1a
Compare
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/refactor-autouse
branch
from
103682a
to
d99a622
Compare
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Code Climate has analyzed commit d3d8e0f and detected 0 issues on this pull request. View more on Code Climate. |
miketheman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the plugin started out, I didn't know how to use the
runtest_setupphase, so I used an automatically-used fixture.I've now removed the fixture, which may have had unintended side effects with other plugins or test suites.
I've also changed the ordering, to be more inline with the expected behaviors, as I laid out in #81 (comment)
I've added a bunch of tests that express the desired precedence behavior in a test module
tests/test_precedence.pyand all the existing tests pass as well 🎉 .This, and a few other bits, should lead to an 0.50.0 release.
Signed-off-by: Mike Fiedler miketheman@gmail.com