Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove post-yield behaviors #90

Merged
merged 2 commits into from
Dec 21, 2021
Merged

chore: remove post-yield behaviors #90

merged 2 commits into from
Dec 21, 2021

Conversation

miketheman
Copy link
Owner

These actions can conflict with other tests within scope,
and should already be covered by pytest_runtest_teardown().

Make teardown a private function, since it's not meant to be used outside this plugin.
Add resetting the socket back to normal as well.

These actions can conflict with other tests within scope,
and should already be covered by `pytest_runtest_teardown()`.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Make this a private function, since it's not meant to be used outside
this plugin.
Add resetting the socket back to normal as well.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman added the chore General maintenance items label Dec 21, 2021
@miketheman miketheman added this to the 0.50.0 milestone Dec 21, 2021
@miketheman miketheman self-assigned this Dec 21, 2021
@codeclimate
Copy link

codeclimate bot commented Dec 21, 2021

Code Climate has analyzed commit 143e495 and detected 0 issues on this pull request.

View more on Code Climate.

@miketheman miketheman merged commit ef2cfcf into main Dec 21, 2021
@miketheman miketheman deleted the post_action branch December 21, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General maintenance items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant