-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ref encode #20
base: master
Are you sure you want to change the base?
Fix ref encode #20
Conversation
Hi @miketonks, Can you have a look at this PR, please? :) And can you merge it if it is OK? it fixes a bug and gets it to generate friendly names for generic types. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing a test for Pet[string]
only getting the package name added to Pet
and not string
Yes thanks, now I have tests for built-in types being type params and the code handling them. |
#