Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref encode #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alirizakeles
Copy link

  • Fix reference, it needs to be encoded url after #
  • Make global subtypes of Generic types look like local, e.g:
GetResponse[github.com/some-org-name/repository/package.Pet] => GetResponse[Pet]

swagger/util.go Outdated Show resolved Hide resolved
swagger/util.go Outdated Show resolved Hide resolved
swagger/util.go Show resolved Hide resolved
swagger/util.go Outdated Show resolved Hide resolved
swagger/util_test.go Outdated Show resolved Hide resolved
@alirizakeles
Copy link
Author

Hi @miketonks,

Can you have a look at this PR, please? :) And can you merge it if it is OK?

it fixes a bug and gets it to generate friendly names for generic types.

Thanks

Copy link

@pmh1wheel pmh1wheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing a test for Pet[string] only getting the package name added to Pet and not string

@alirizakeles
Copy link
Author

Still missing a test for Pet[string] only getting the package name added to Pet and not string

Yes thanks, now I have tests for built-in types being type params and the code handling them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants