feat: Floating window support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
mikew
commented
Aug 31, 2024
lua/nvim-drawer/init.lua
Outdated
| @@ -276,6 +280,120 @@ function mod.create_drawer(opts) | |||
| instance.state.previous_bufnr = final_bufnr | |||
| end | |||
|
|
|||
| function instance.get_win_config() | |||
There was a problem hiding this comment.
This function + nvim_win_set_config kind of makes set_size moot, it does the same thing.
mikew
commented
Aug 31, 2024
lua/nvim-drawer/init.lua
Outdated
| --- @field margin? number | ||
| --- @field width? number | ||
| --- @field height? number | ||
| --- @field anchor? 'NE' | 'NC' | 'NW' | 'CE' | 'CC' | 'CW' | 'SE' | 'SC' | 'SW' |
There was a problem hiding this comment.
add N | E | S | W | C since they're more ergonomic, but they should just resolve to NC / CE / SC / CW / CC since those make the code much cleaner
mikew
commented
Aug 31, 2024
Comment on lines
-527
to
-532
|
|
||
| local winid = instance.get_winid() | ||
| instance.set_size(instance.state.size) | ||
|
|
||
| local bufnr = instance.state.previous_bufnr | ||
| vim.api.nvim_win_set_buf(winid, bufnr) |
There was a problem hiding this comment.
Personal milestone!
It always irked me that the restore logic here was so involved, even going back to vim-drawer: https://github.com/mikew/vim-drawer/blob/38c760debb0e85a3586878ea40ff6cc978fea054/autoload/drawer.vim#L290-L300
Really, .open and .close should suss themselves out correctly without having to account for any weird side effects, and finally they do!
mikew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's no easy way to resize floating windows with a mouse, I've also added a
toggle_zoom()function. This also works on splits.Preview
Screen.Recording.2024-08-30.at.3.44.03.AM.mov.mp4