-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add 'sleep-extractor' option (closes #964)
(would have been nice if this were possible without code duplication)
- Loading branch information
Showing
2 changed files
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3afd362
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've noticed there are no command-line options in option.py for
sleep-extractor
(andsleep-request
), although we have--sleep
.Is this intentional? Otherwise, I could add them if you think they would be useful.
3afd362
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of. I didn't think it was necessary to add them since 1) they are more specialized than the standard
--sleep
and 2) it is always possible to do-o sleep-extractor=N
or-o sleep-request=N
if one want's to set these options via cmdline.Feel free to open a PR if you'd like to have them as regular cmdline options.