[postprocessor:ugoira] improve error messages (#406)

mikf · Aug 31, 2019 · 5fcebb6 · 5fcebb6
1 parent f02a768
commit 5fcebb6
Showing 1 changed file with 19 additions and 13 deletions.
diff --git a/gallery_dl/postprocessor/ugoira.py b/gallery_dl/postprocessor/ugoira.py
@@ -103,20 +103,26 @@ def run(self, pathfmt):
 
             # invoke ffmpeg
             pathfmt.set_extension(self.extension)
-            if self.twopass:
-                if "-f" not in args:
-                    args += ["-f", self.extension]
-                args += ["-passlogfile", tempdir + "/ffmpeg2pass", "-pass"]
-                self._exec(args + ["1", "-y", os.devnull])
-                self._exec(args + ["2", pathfmt.realpath])
+            try:
+                if self.twopass:
+                    if "-f" not in args:
+                        args += ["-f", self.extension]
+                    args += ["-passlogfile", tempdir + "/ffmpeg2pass", "-pass"]
+                    self._exec(args + ["1", "-y", os.devnull])
+                    self._exec(args + ["2", pathfmt.realpath])
+                else:
+                    args.append(pathfmt.realpath)
+                    self._exec(args)
+            except OSError as exc:
+                print()
+                self.log.error("Unable to invoke FFmpeg (%s: %s)",
+                               exc.__class__.__name__, exc)
+                pathfmt.realpath = pathfmt.temppath
             else:
-                args.append(pathfmt.realpath)
-                self._exec(args)
-
-        if self.delete:
-            pathfmt.delete = True
-        else:
-            pathfmt.set_extension("zip")
+                if self.delete:
+                    pathfmt.delete = True
+                else:
+                    pathfmt.set_extension("zip")
 
     def _exec(self, args):
         out = None if self.output else subprocess.DEVNULL