Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviantArt comments? #1800

Closed
Twi-Hard opened this issue Aug 26, 2021 · 4 comments
Closed

DeviantArt comments? #1800

Twi-Hard opened this issue Aug 26, 2021 · 4 comments

Comments

@Twi-Hard
Copy link

Could you add an option to download comments into the json?
https://www.deviantart.com/developers/http/v1/20210526
image

@Wiiplay123
Copy link
Contributor

Seconded, looks like it would be easy to implement, too.
I don't have time to work on it but hopefully someone else can.

Implementing /comments/profile/{username} would be a great option too for when you download a user's entire profile, though I'm not sure how updating it would work (like if you download the comments once, then someone deletes their comment, but you want to keep that comment in the JSON while also updating with any new comments)

@mikf
Copy link
Owner

mikf commented Aug 29, 2021

I've added a comments option, which when enabled does some extra API call(s) for each deviation and adds a list of all comments to the metadata dict. Each comment entry currently looks like

        {
          "body": "Merci.",
          "commentid": "9B9F56CE-57B1-F657-C180-576FFFA4CA34",
          "hidden": null,
          "is_featured": false,
          "is_liked": false,
          "likes": 0,
          "parentid": "30A70783-969C-07C4-58C6-CC66145B2759",
          "posted": "2011-10-06T16:44:07-0700",
          "replies": 0,
          "user": {
            "type": "regular",
            "usericon": "https://a.deviantart.net/avatars/r/u/rufina-tomoyo.gif?3",
            "userid": "FD37693A-E2D0-C3D9-6322-CBA64D2F1A05",
            "username": "Rufina-Tomoyo"
          }
        },

Should I remove/simplify some of that, or is it OK like this?

As for updating comments: Any extra metadata files currently just overwrite the previous one. There is no skip option for those like there is for regular downloaded files.

@Twi-Hard
Copy link
Author

Twi-Hard commented Aug 29, 2021

Thank you so much :)
It's good how it is btw.. the more data the better. It could all be useful.
Edit: Should this be closed?

@mikf
Copy link
Owner

mikf commented Sep 3, 2021

I've left this open in case something wasn't right, should be changed, etc, but yeah, this should be closed if everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants