-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow gallery-dl.conf
to be named gallery-dl.conf.txt
and gallery-dl.conf.json
#2333
Comments
Surely people using this can turn on file extensions in Windows? It's not difficult and is incredibly useful. |
Independently how it's useful and easy to set up, it's disabled by default. And some people will face the problem. Since they create |
It's a CLI program, and no matter what you use here, the CLI will always show you the real file extensions, and you can easily rename files from there as well.. |
There are 46 issues about "Deviantart 429 Error". (Edit: with mention of it.) Do you think that everybody knows basic shell commands? For some people just to run I see that there is a problem and resolving is trivial. Why not. |
Dunno, but this is even the most basic of the basic ones, like But you're probably right about this, with regard to the issue count. So, don't get me wrong, I'm not against this change. -- Edit -- One thing that definitely could be improved here is maybe adding an additional line to the debug status messages when running in This wasn't an issue for me personally yet, because you can actually tell from the verbose messages from the extractor if you are using any custom auth settings or something. More, you can always check the output settings with But again, something along the lines of what yt-dlp is currently doing might be a good idea:
So, the first debug message shows the options provided from the CLI, and the second line the user config file, with it's entire path, and then following in the square-brackets the actual options set by this file (which isn't even that important, in my opinion, a simple message a la |
Yes, I also suggested this before. |
Honestly, I would question why someone is using a CLI utility if they can't even change file extensions via the CLI. Or just turn them on in the Windows explorer. |
If someone use the Windows Explorer to run, create or configure a CLI utility, that person should buy one of numerous downloaders for windows available on the internet. I felt kind a shame for the author of this "issue"... |
Because I want to decrease the issue's count and help a bit to people who are not "elite" because they want to download the content with the best tool, but it's their the first experience with CLI? Maybe lets start to close all issues if there is an answer in the other one? Just marks these issues as a duplicate and close for commenting. Okay, @mikf your opinion about it? BTW, the repost of my old message: Add in Read also Or add a command to open (and create an empty file if it does not exist) the config file. |
I don't think that it should automatically use these files, as that would be just further enabling user mistakes. But I agree with @AlttiRi that the problem is real, I think implementing a check for these mistakenly named files and displaying a warning/instructions would be OK. |
Allow
gallery-dl.conf
file to be additionally namedgallery-dl.conf.txt
.Since by default Windows hides the extensions in File Explorer.
Some people created
gallery-dl.conf.txt
and think that they createdgallery-dl.conf
that is wrong. It generates additional issues here with their problems.And
gallery-dl.conf.json
for syntax highlighting in text editors.gallery-dl/gallery_dl/config.py
Lines 25 to 38 in 3acfe68
The text was updated successfully, but these errors were encountered: