Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgbb] Fix user extraction, add displayname #4626

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[imgbb] Fix user extraction, add displayname #4626

merged 1 commit into from
Oct 9, 2023

Conversation

Hrxn
Copy link
Contributor

@Hrxn Hrxn commented Oct 5, 2023

Just noticed this while extracting some albums.

Seems to fix it, of course, feel free to make any changes / adjustments etc.

@Hrxn
Copy link
Contributor Author

Hrxn commented Oct 5, 2023

displayname as in Displayed User Name, or "Full" User Name, whatever one wants to call it.

Change it if you're not happy with the name. I've picked it in analogy to displayName in behance.py, which works the same way, basically.

I've made tests with single links, couple of albums and a user. Seems working fine so far.
Well, user extraction is still running, should've taken a smaller example.

@Hrxn
Copy link
Contributor Author

Hrxn commented Oct 5, 2023

I've also checked it with a linter (https://github.com/astral-sh/ruff), might as well start doing it the right way when starting at all.

Aaaaand spoke too soon.
Of course.

ImgbbUserExtractor did extract all of the images listed on the profile page, but it apparently does not terminate.
It's still running, continually skipping downloads it already made. Seems like an infinite loop. Yeah, pretty sure, no need to wait here any longer, I think.

Well, I did not touch any pagination function or something, so, it's probably not my fault.. 😄

@mikf mikf merged commit b846f56 into mikf:master Oct 9, 2023
0 of 8 checks passed
mikf added a commit that referenced this pull request Oct 9, 2023
@mikf
Copy link
Owner

mikf commented Oct 9, 2023

I've made tests with single links, couple of albums and a user. Seems working fine so far.

It doesn't work for albums without user info when logged in. (https://ibb.co/album/s9SKDs)
In this case, it extracts the name of the logged in user.

Don't worry about, though. I'll fix this myself before the next release.

Well, I did not touch any pagination function or something, so, it's probably not my fault.. 😄

The last real update to the imgbb code was in 2020 (9219141).
Not surprising that something broke during this time.

Fixed in 95c280c

mikf added a commit that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants