-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sigpy 0.1.25 is incompatible with newer numpy versions #123
Labels
bug
Something isn't working
Comments
I have tried sigpy with a pre-release version of numba, and can confirm that it works with the fixes I posted above. |
cool, thanks! let's wait til the numba version is released then |
@hcmh Looks like it's out! When you're able, can you please create a PR with the fixes? |
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a low-priority issue, as sigpy requires numba, which also does not work with numpy 1.24.
When trying to run the tests on Arch Linux, all tests fail because sigpy uses
np.float
(andnp.complex
andnp.int
), which was deprecated in numpy 1.20 and has been removed in numpy 1.24.0.np.float32
/64
andnp.floating
are fine, only plainnp.float
,np.complex
andnp.int
are a problem.Steps to reproduce the behavior:
./run_tests.sh
... and 26 more, for all other tests.
Expected behavior would be that the tests fail a bit later because of the incompatibility of numba (any currently released version) and numpy>=1.24
I have changed all instances of
np.float
->float
(andnp.complex
,np.int
) at https://github.com/hcmh/sigpy/tree/numpy-float-changes in case you want to apply this now. I have not created a pull request yet, as it isThe text was updated successfully, but these errors were encountered: