Remove deprecated type specifiers #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure eventual compatibility with numpy>=1.24, as np.float has been removed there. For now however, numba is not compatible with numpy>=1.24, so sigpy needs numpy<1.24 anyway.
np.complex and np.int have also been removed, and are replaced here by their python equivalents.
|
This would be really helpful so we don't have to downgrade our numpy version! Is there a timeline for merge? Any chance of merging before ISMRM... so we can spend the week coding up new MRI apps? :) |
|
Sorry, I didn't have time to test. I'll merge now but will revert if folks have issues. |
|
This change doesn't seem to be in the latest pypy package available via pip. Any thoughts? |
The last PyPi release is from April, this fix was merged in May. For the pypulseq project (https://github.com/imr-framework/pypulseq), we will probably remove the sigpy dependency because of this 😞 |
curtcorum
reviewed
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all instances of
np.complex -> complex
np.float -> float
np.bool -> bool
np.int -> int
as they are depcreated since numpy 1.20.
Closes #123.