fix: keystore file not found exception (ReVanced#57)

* fix: keystore file not found exception * the fix * fix oopsies
mikjori · Jun 22, 2022 · 5b8537e · 5b8537e
1 parent 7d8a61c
commit 5b8537e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/main/kotlin/app/revanced/cli/signing/Signing.kt b/src/main/kotlin/app/revanced/cli/signing/Signing.kt
@@ -18,10 +18,9 @@ object Signing {
  // the reason is, in case the signer fails
  // it does not damage the output file
  println("[signing]")
- val keyStore = Signer(signingOptions).signApk(alignedOutput, signedOutput)
+ Signer(signingOptions).signApk(alignedOutput, signedOutput)
 
- // afterwards copy over the file and the keystore to the output
+ // afterwards copy over the file to the output
  signedOutput.copyTo(outputFile, true)
- keyStore.copyTo(outputFile.resolveSibling(keyStore.name), true)
  }
 }
diff --git a/src/main/kotlin/app/revanced/utils/signing/Signer.kt b/src/main/kotlin/app/revanced/utils/signing/Signer.kt
@@ -49,7 +49,7 @@ internal class Signer(
  return JcaX509CertificateConverter().getCertificate(builder.build(signer)) to pair.private
  }
 
- fun signApk(input: File, output: File): File {
+ fun signApk(input: File, output: File) {
  Security.addProvider(BouncyCastleProvider())
 
  // TODO: keystore should be saved securely
@@ -74,7 +74,5 @@ internal class Signer(
  signer.setOutputApk(output)
 
  signer.build().sign()
-
- return ks
  }
 }