Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in <style> element cannot contain text like "<something>" #341

Closed
eugeneko opened this issue Aug 7, 2022 · 3 comments
Closed

Comments in <style> element cannot contain text like "<something>" #341

eugeneko opened this issue Aug 7, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@eugeneko
Copy link
Contributor

eugeneko commented Aug 7, 2022 •
edited
Loading

This RML file cannot be parsed because parsing <> happens before parsing /**/, so it doesn't ignore <body> tag in the comment.

This snippet is considered valid by https://validator.w3.org/ tho

<rml>
    <head>
        <style>
            body {
                /* <body> */
                width: 100%;
                height: 100%;
            }
        </style>
    </head>
    <body>
    </body>
</rml>
mikke89 added a commit that referenced this issue Aug 7, 2022
@mikke89
Make style tags accept xml reserved characters such as in /* <body> *…
e9c3dde 
…/, see #341
@mikke89
Copy link
Owner

mikke89 commented Aug 7, 2022

It is tempting to say "don't do that", but the fix seemed to be very easy (see commit) so I went ahead with it.

Let me know if this change works for you or there are any issues.

@xland
Copy link

xland commented Aug 8, 2022

Does this commit incur runtime costs?

@mikke89
Copy link
Owner

mikke89 commented Aug 8, 2022

No, at least nothing that is measurable.

@mikke89 mikke89 added the enhancement New feature or request label Aug 10, 2022
@mikke89 mikke89 closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xland @mikke89 @eugeneko