GLFW_VK backend #360
Merged
GLFW_VK backend #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This looks good to me. I just tested it and didn't find any issues. I think using this_thread for sleep is the right approach. If you could just remove the commented out code then I will merge this :) |
|
@mikke89 I deleted the commentary as you asked. |
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested resizing (minimizing) and samples worked well.
I suggest to test them on your own too, but I don't think that there's something wrong. ¯_(ツ)_/¯
Also take a notice to section where SDL_Delay was used, I mean is it fine to use thread? Because glfw doesn't provide (or I didn't find it) the functionality to sleep the thread. So I choice a such variant.
Otherwise if you agreed with a such solution (I mean about this_thread) you can delete the commentary of SDL code.
Don't forget to add new backend for CI.