Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify loaddocument sample to take model path as param #453

Closed
wants to merge 1 commit into from
Closed

Modify loaddocument sample to take model path as param #453

wants to merge 1 commit into from
+16 −4

Conversation

Dakror
Copy link
Contributor

@Dakror Dakror commented Apr 22, 2023

Answering my own question in #452 , i made small changes to the loaddocument sample so that it can be used to quickly load up a given rml file and check it out.

@Dakror Dakror mentioned this pull request Apr 22, 2023
Closed
@mikke89
Copy link
Owner

mikke89 commented Apr 24, 2023

Hey, the intended way to quickly load rml files is through the VisualTests application. You can quickly put new RML files in the Tests/Data/VisualTests directory, and they will show up there. It also has screenshot and comparison capabilities, which are very helpful to avoid regressions, as well as reloading.

This PR isn't a large change, but I want the loaddocument to be the minimum canonical example it can be. Since we already have another intended way to do this, I am closing this one.

@mikke89 mikke89 closed this Apr 24, 2023
@Dakror
Copy link
Contributor Author

Dakror commented Apr 25, 2023

Sounds good! didnt see that in the Visual Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dakror @mikke89