Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Input Method Editor #541

Merged
merged 42 commits into from
Jul 2, 2024
Merged

Text Input Method Editor #541

merged 42 commits into from
Jul 2, 2024

Commits on May 14, 2024

  1. Add visual feedback for IME composition in text inputs

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e6c3b54 View commit details
    Browse the repository at this point in the history

  2. Reset the IME composition range when the input value changes.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8369f7c View commit details
    Browse the repository at this point in the history

  3. Comment unused parameters.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b9a3220 View commit details
    Browse the repository at this point in the history

  4. Implement the WidgetTextInput::GetLineIMEComposition() method.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    16614a6 View commit details
    Browse the repository at this point in the history

  5. Fix implicit type conversion.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    25a3c0b View commit details
    Browse the repository at this point in the history

  6. Create a sample of an advanced use of IME.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b004492 View commit details
    Browse the repository at this point in the history

  7. Implement UTF-16 to UTF-8 conversion instead of using the Windows bac… 

    …kend platform.
    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    567ad45 View commit details
    Browse the repository at this point in the history

  8. Move ConvertCharacterOffsetToByteOffset and ConvertByteOffsetToCharac… 

    …terOffset to StringUtilities.
    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ad1f30f View commit details
    Browse the repository at this point in the history

  9. Rename UpdateCompositionRange to SetCompositionRange.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    30be693 View commit details
    Browse the repository at this point in the history

  10. Move the IME implementation from a sample to the library.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d31daf8 View commit details
    Browse the repository at this point in the history

  11. Use GNU Unifont for the IME sample. 

    GNU Unifont is used as a lightweight replacement of Noto Sans.
    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a043fb9 View commit details
    Browse the repository at this point in the history

  12. Deactivate only the same text input method context.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2632627 View commit details
    Browse the repository at this point in the history

  13. Properly export new classes and function.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    92d8f70 View commit details
    Browse the repository at this point in the history

  14. Add back TextInputMethodContext::GetScreenBounds().

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ca458c2 View commit details
    Browse the repository at this point in the history

  15. Respect the text input length restriction with IME composition.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9c90052 View commit details
    Browse the repository at this point in the history

  16. Load Win32 system fonts in IME sample

    @mikke89 @ShawnCZek
    mikke89 authored and ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8d57c25 View commit details
    Browse the repository at this point in the history

  17. Fix text disappearing from textarea.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d31d8bd View commit details
    Browse the repository at this point in the history

  18. Add the IME sample only if a Win32 backend is used.

    @ShawnCZek
    ShawnCZek committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3f801d7 View commit details
    Browse the repository at this point in the history

  19. Fix a conditional for locating system font files. 

    Co-authored-by: Michael R. P. Ragazzon <mikke89@users.noreply.github.com>
    @ShawnCZek @mikke89
    ShawnCZek and mikke89 authored May 14, 2024
    Configuration menu
    Copy the full SHA
    2583895 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Explain the IME sample.

    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a5c9995 View commit details
    Browse the repository at this point in the history

  2. Use window_handle instead of GetActiveWindow().

    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    350e3f6 View commit details
    Browse the repository at this point in the history

  3. Remove coupling of IME contetx via friend keyword.

    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b8bd402 View commit details
    Browse the repository at this point in the history

  4. Ensure that valid pointers are accessed during the lifetime of Widget… 

    …TextInputIMEContext.
    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e49dc87 View commit details
    Browse the repository at this point in the history

  5. Remove inconsistent IME prefix from method names.

    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c1219a6 View commit details
    Browse the repository at this point in the history

  6. Construct IME context only when in use.

    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    853a777 View commit details
    Browse the repository at this point in the history

  7. Make TextInputMethodEditor::EndComposition() an implementation detail.

    @ShawnCZek
    ShawnCZek committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6699d57 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Make the text input handler multipurpose. 

    Incorporated requested changes in the pull request:

* Rename TextInputMethodContext to TextInputContext.
* Make TextInputMethodEditor backend-specific.
* Make the TextInputMethodEditor behavior well-defined instead of relying on assertions.
* Add TextInputHandler (reimplementation of mikke89#548) as a global replacement (context-dependent).
* Retrieve the text input's bounding box via an element utility function.
    @ShawnCZek
    ShawnCZek committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    a269d23 View commit details
    Browse the repository at this point in the history

  2. Rename SetIMERange to SetCompositionRange.

    @ShawnCZek
    ShawnCZek committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    f549e05 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ime_visual_feedback 

    Conflicts:
	Samples/readme.md
    @ShawnCZek
    ShawnCZek committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    045f781 View commit details
    Browse the repository at this point in the history

  4. Comment out unused parameter variables.

    @ShawnCZek
    ShawnCZek committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    eb955c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Revert "Construct IME context only when in use." 

    This reverts commit 853a777.
    @ShawnCZek
    ShawnCZek committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d8094b3 View commit details
    Browse the repository at this point in the history

  2. Rename instances of TextInputContext to input_context.

    @ShawnCZek
    ShawnCZek committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c8df9a1 View commit details
    Browse the repository at this point in the history

  3. Fix header files of TextInputContext and TextInputHandler.

    @ShawnCZek
    ShawnCZek committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    25588b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Document TextInputContext and TextInputHandler classes.

    @ShawnCZek
    ShawnCZek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d944506 View commit details
    Browse the repository at this point in the history

  2. Move the ownership of the IME editor to backends.

    @ShawnCZek
    ShawnCZek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9abf64c View commit details
    Browse the repository at this point in the history

  3. Complete the composition when the user tries to interact with other e… 

    …lements.
    @ShawnCZek
    ShawnCZek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    869f0d0 View commit details
    Browse the repository at this point in the history

  4. Rename OnBlur/OnFocus to OnActivate/OnDeactivate.

    @ShawnCZek
    ShawnCZek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e11e96e View commit details
    Browse the repository at this point in the history

  5. Rename text_input_method_context to text_input_context.

    @ShawnCZek
    ShawnCZek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f3bb2bc View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Fix the name of the include guard for TextInputContext and TextInputH… 

    …andler.
    @ShawnCZek
    ShawnCZek committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    fa4d3bc View commit details
    Browse the repository at this point in the history

  2. Simplify the ownership of text input contexts.

    @ShawnCZek
    ShawnCZek committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    3a16064 View commit details
    Browse the repository at this point in the history

  3. Add a missing class definition.

    @ShawnCZek
    ShawnCZek committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    874b3f8 View commit details
    Browse the repository at this point in the history

  4. Store handler in the text widget input context 

    The element's context is not available during destruction, so the call to `OnDestroy` was never executed. Instead, store the handler it was constructed with so that we can call `OnDestroy` with that.
    @mikke89
    mikke89 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    3d9ec36 View commit details
    Browse the repository at this point in the history