Fixing for Rml 5.* releases Vulkan issue #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, but keep original header for version 1.0 for maximum supporting of wide range devices and user base; fixing all validation errors, the problem was in function that used for outside usage, but our case was that we need to use inside in our render pass instance.
…lad header for vulkan 1.3 version); returned debugging to default state (not so detailed).
…reported by thalhammer, ancient issue)
|
Thanks for the fix! This looks good to me, I'll wait a bit to see if anyone else has any input. The commit history is very noisy, but I can always squash merge it. |
|
Hi, thanks for the headsup. |
|
Thanks for chiming in, I am happy with this change as it is then. And thanks again for the fixup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ancient issue, because first mentioned by @Thalhammer (see #430).
Example demonstation of bug:
The fix is really straightforward and I forgot why I keep incorrect usage of semaphores for queue submit, but I didn't forget about that issue after 2 years...
I would like to call @Thalhammer for testing in his environment and report that there's no any issues too.