Update dependency check in RmlUiConfig #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpersano
force-pushed
the
master
branch
2 times, most recently
from
fcfe493 to
39b69cc
Compare
An extra parameter was added to the report_dependency_found_or_error macro in Utilities.cmake, but RmlUiConfig wasn't updated. As a result, find_package(RmlUi) fails because it can't find FreeType (since it looks for the Freetype target, not Freetype::Freetype).
|
This is great, thanks a lot! I forgot to update this one indeed. This reminds me, I actually have a local script for testing various installation methods and consuming the library, and it did indeed catch this when testing just now. I should try to find some time to add that to the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra parameter was added to the report_dependency_found_or_error macro in Utilities.cmake, but RmlUiConfig wasn't updated.
As a result, find_package(RmlUi) fails because it can't find Freetype (since it looks for the Freetype target, not Freetype::Freetype).