-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix :as option in passwordless_for #174
Conversation
Hmm, that looks weird? Do you use the bundled mailer? It shouldn't use |
Did you get a chance to look more into this, @yshmarov |
I will try to make some time to test this later this week. |
It is failing on this line: with this change it works for me: def passwordless_sign_in(resource)
session = Passwordless::Session.create!(authenticatable: resource)
# magic_link = Passwordless::Engine.routes.url_helpers.send(
# :"confirm_#{session.authenticatable_type.tableize}_sign_in_url",
# session,
# session.token
# )
magic_link = url_for(
{
controller: "passwordless/sessions",
action: "confirm",
id: session.id,
token: session.token,
authenticatable: session.authenticatable_type.singularize.downcase,
resource: session.authenticatable_type.tableize
}
) |
Of course, I didn't realise it was the test helpers. Fixed now, thanks! |
Fixes #168
@yshmarov, @jpatters thank you for your reports. Could you try and see whether this fixes your problems? Thanks!