Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG #200

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Update CHANGELOG #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcfa59
Update CHANGELOG
yenshirak Jan 24, 2024
bbe4b5b
Fix format
yenshirak Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Changelog

## 1.3.0

### Changed

- The default `from` of the parent mailer won't be overridden if the `default_from_address` option is set to `nil` (#198)

### Added

- Added `paranoid` option to display the email sent notice even when the resource is not found (#196)
- Added `parent_controller` option to set the `SessionsController` parent class (#199)
- Added `only_path` param to `SystemTestCase#passwordless_sign_in` and `SystemTestCase#passwordless_sign_out` (#197)


## 1.2.0

### Added
Expand Down
4 changes: 2 additions & 2 deletions app/controllers/passwordless/sessions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def normalized_email_param
def handle_resource_not_found
if Passwordless.config.paranoid
@resource = authenticatable_class.new(email: normalized_email_param)
@disable_after_session_save_callback = true
@skip_after_session_save_callback = true
else
raise(
ActiveRecord::RecordNotFound,
Expand All @@ -189,7 +189,7 @@ def handle_resource_not_found
end

def call_after_session_save
return if @disable_after_session_save_callback
return if @skip_after_session_save_callback

if Passwordless.config.after_session_save.arity == 2
Passwordless.config.after_session_save.call(@session, request)
Expand Down