Remove trailing nulls from id3v1 strings in ParseTag() #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a Also is there a reason you used an anonymous struct instead of |
|
I didn't know about |
|
I have fixed the issue that was causing Travis build to fail. |
|
The current error is caused because of Travis not being able to build Go itself from the tip branch. All other versions pass. |
|
we have the same problem with trailing nulls in v2.TextFrame |
frodeaa
pushed a commit
to frodeaa/dircast
that referenced
this pull request
Mar 31, 2015
this is caused by a bug in id3-go, it does not remove the trailing nulls somewhat addressed in mikkyang/id3-go#8, but the pull request does not fix all cases, like removing null from any TextFrame, like the TCON category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.