fix(manager): wait after Scylla config change to let SM pick up the c… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikliapko
added a commit
that referenced
this pull request
Dec 20, 2024
Error message Manager returns for enospc scenario has been changed to more generic one (#1). So, it doesn't make much sense to verify it. Moreover, there is a plan to fix check free disk space behaviour and the whole test will probably require rework to be done (#2). refs: #1 - scylladb/scylla-manager#4087 #2 - scylladb/scylla-manager#4184
mikliapko
added a commit
that referenced
this pull request
Dec 24, 2024
Fix changes directory for startup script upload from /tmp to $HOME. The change is required for DB nodes deployed in Cloud where /tmp dir is mounted with noexec option what makes script execution impossible there. As per discussion (#1), for DB nodes deployed in SCT startup_script can be executed either from $HOME or /tmp. refs: #1: scylladb#9608
mikliapko
added a commit
that referenced
this pull request
Dec 27, 2024
Fix changes directory for startup script upload from /tmp to $HOME. The change is required for DB nodes deployed in Cloud where /tmp dir is mounted with noexec option what makes script execution impossible there. As per discussion (#1), for DB nodes deployed in SCT startup_script can be executed either from $HOME or /tmp. refs: #1: scylladb#9608
mikliapko
added a commit
that referenced
this pull request
Dec 30, 2024
According to comment (1), set ks strategy and rf is not needed if restoring the schema within one DC. It should be brought back after implementation of (2) which will unblock schema restore into a different DC. For now, it's possible to restore schema only within one DC. Refs: #1: scylladb/scylla-manager#4041 issuecomment-2565489699 #2: scylladb/scylla-manager#4049
mikliapko
added a commit
that referenced
this pull request
Dec 31, 2024
Firewall should be disabled for RHEL-like distributions. Otherwise, it blocks incoming requests to 3000 monitoring node (1). The same operation has been already implemented for db nodes setup and only refactored here. refs: #1: scylladb#9630
mikliapko
added a commit
that referenced
this pull request
Dec 31, 2024
Temporary workaround for docker installation on RHEL9 distro because of the issue (1). In provided fix docker packages are installed manually for repo, hardcoding the OS version ($releasever) to specific value in repo file /etc/yum.repos.d/docker-ce.repo. After issue resolution, we can return the previous approach with installation script. refs: #1: moby/moby#49169
mikliapko
added a commit
that referenced
this pull request
Dec 31, 2024
Firewall should be disabled for RHEL-like distributions. Otherwise, it blocks incoming requests to 3000 monitoring node (1). The same operation has been already implemented for db nodes setup and only refactored here. refs: #1: scylladb#9630
mikliapko
added a commit
that referenced
this pull request
Dec 31, 2024
Firewall should be disabled for RHEL-like distributions. Otherwise, it blocks incoming requests to 3000 monitoring node (1). The same operation has been already implemented for db nodes setup and only refactored here. refs: #1: scylladb#9630
mikliapko
added a commit
that referenced
this pull request
Jan 2, 2025
According to comment (1), set ks strategy and rf is not needed if restoring the schema within one DC. It should be brought back after implementation of (2) which will unblock schema restore into a different DC. For now, it's possible to restore schema only within one DC. Refs: #1: scylladb/scylla-manager#4041 issuecomment-2565489699 #2: scylladb/scylla-manager#4049
mikliapko
added a commit
that referenced
this pull request
Jan 3, 2025
Temporary workaround for docker installation on RHEL9 distro because of the issue (1). In provided fix docker packages are installed manually for repo, hardcoding the OS version ($releasever) to specific value in repo file /etc/yum.repos.d/docker-ce.repo. After issue resolution, we can return the previous approach with installation script. refs: #1: moby/moby#49169
mikliapko
added a commit
that referenced
this pull request
Jan 3, 2025
Firewall should be disabled for RHEL-like distributions. Otherwise, it blocks incoming requests to 3000 monitoring node (1). The same operation has been already implemented for db nodes setup and only refactored here. refs: #1: scylladb#9630
mikliapko
added a commit
that referenced
this pull request
Jan 3, 2025
Changes: - Removed scylla version hardcode for Azure job. The image defined in azure_image_db contains Scylla 5.2.1 which outdated. Moreover, there are no restrictions with passing scylla_version directly. - Renamed jenkinsfile to address recent move from Centos-based image for Azure jobs to RHEL-based (1). refs: #1: scylladb#9631
mikliapko
added a commit
that referenced
this pull request
Jan 8, 2025
Error message Manager returns for enospc scenario has been changed to more generic one (#1). So, it doesn't make much sense to verify it. Moreover, there is a plan to fix check free disk space behaviour and the whole test will probably require rework to be done (#2). refs: #1 - scylladb/scylla-manager#4087 #2 - scylladb/scylla-manager#4184
mikliapko
added a commit
that referenced
this pull request
Jan 8, 2025
According to comment (1), set ks strategy and rf is not needed if restoring the schema within one DC. It should be brought back after implementation of (2) which will unblock schema restore into a different DC. For now, it's possible to restore schema only within one DC. Refs: #1: scylladb/scylla-manager#4041 issuecomment-2565489699 #2: scylladb/scylla-manager#4049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.