Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use InteliJ webstorm (free propaganda here), and it is convenient when the code has inline documentation.
First I noticed that the return type was not defined in the module declarations.
Looking into the implementation I concluded that it must return a number .
I also changed the return type of the comparison function (that by the way I extracted in a separate interface). The previous declaration accepts
null
orundefined
as return types. I think that this would lead to some confusion, e.g.bounds.lt(array, y) + 1 != bounds.ge(array, y)
, in an array wherey
appears multiple times.The screenshot shows how the inline documentation appears in the IDE